From dbd26b4838b4d99c7e4c9ca9a8bb049bc2e9f715 Mon Sep 17 00:00:00 2001 From: peterwmwong Date: Sat, 29 Dec 2018 11:28:07 -0600 Subject: [PATCH] test: remove unused --expose-native-as V8 flag test-preload.js was using a V8 flag (`--expose-native-as`) that made an V8 internally used object available. As this test does not use this object, this commit removes the usage of this flag. In some distant past, this internally used object may have had some external use, but currently is essentially an empty object. In the near future, the V8 internal infrastructure (JS Natives) producing the object exposed by `--expose-native-as` will be phased out. For more details, visit: https://bugs.chromium.org/p/v8/issues/detail?id=7624 PR-URL: https://github.com/nodejs/node/pull/25275 Reviewed-By: Anna Henningsen Reviewed-By: Colin Ihrig Reviewed-By: Anto Aravinth --- test/parallel/test-preload.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/parallel/test-preload.js b/test/parallel/test-preload.js index 71c282b9fbfaea..566a3eec546ba2 100644 --- a/test/parallel/test-preload.js +++ b/test/parallel/test-preload.js @@ -155,7 +155,7 @@ if (common.isWindows) { // https://github.com/nodejs/node/issues/1691 process.chdir(fixtures.fixturesDir); childProcess.exec( - `"${nodeBinary}" --expose_natives_as=v8natives --require ` + + `"${nodeBinary}" --require ` + `"${fixtures.path('cluster-preload.js')}" cluster-preload-test.js`, function(err, stdout, stderr) { assert.ifError(err);