From 5f9c1815b6df3a7ecb9e4d16caff34325af27068 Mon Sep 17 00:00:00 2001 From: Quramy Date: Tue, 3 Sep 2024 19:08:56 +0900 Subject: [PATCH] fix: Don't stop wait to navigate preview html --- packages/storycrawler/src/browser/stories-browser.ts | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/packages/storycrawler/src/browser/stories-browser.ts b/packages/storycrawler/src/browser/stories-browser.ts index 2b52490f7..c1c9a280f 100644 --- a/packages/storycrawler/src/browser/stories-browser.ts +++ b/packages/storycrawler/src/browser/stories-browser.ts @@ -62,13 +62,14 @@ export class StoriesBrowser extends BaseBrowser { this.logger.debug('Wait for stories definition.'); await this.page.goto(this.connection.url); let stories: Story[] | null = null; - await this.page.goto( + + // Note: + // Don't wait fo this `goto` promise. Sometimes Chromimue emits timeout error and this navigation and causes whole screenshot process abortion. + // For detail, see https://github.com/reg-viz/storycap/issues/896#issuecomment-2317248668 + this.page.goto( this.connection.url + '/iframe.html?selectedKind=story-crawler-kind&selectedStory=story-crawler-story', - { - timeout: 60_000, - waitUntil: 'domcontentloaded', - }, ); + await this.page.waitForFunction( () => (window as ExposedWindow).__STORYBOOK_CLIENT_API__ ||