Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Add Observer_SetMode hook #207

Closed
Lopol2010 opened this issue Aug 14, 2021 · 4 comments · Fixed by #208
Closed

[Feature Request] Add Observer_SetMode hook #207

Lopol2010 opened this issue Aug 14, 2021 · 4 comments · Fixed by #208

Comments

@Lopol2010
Copy link
Contributor

With this hook you can block some spectating modes. I want to allow players only be in "First Person", "Thir Person Free", "Free Look".
This was referenced Aug 16, 2021
Merged
Merged
@Lopol2010
Copy link
Contributor Author

Lopol2010 commented Aug 16, 2021 •
edited
Loading

(Question not related to an issue)
Do i understand correctly that in order to successfully add new hook all virtual functions must be appeneded to the end of class's vtable? Because when i have the same code but with my function insterted in middle, then nothing works and there is errors in server. Sorry if this is bad place to ask.

@hajimura
Copy link

All new hooks and members should be added to the end of the list. Otherwise it breaks backward compatibility

@Lopol2010
Copy link
Contributor Author

Thank you for the answer!

@SergeyShorokhov
Copy link
Member

Closed by #208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement RG_CBasePlayer_Observer_SetMode hook
3 participants
@hajimura @SergeyShorokhov @Lopol2010