-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Relay v2.0.0 #159
Comments
Yeah, I think we'll need to release a breaking change here to move to the new context API, if Relay 1.7.0 does. |
Are there any plans on Relay 2.0.0 support? I want to upgrade my app to the newest version of Relay (I'm using Found Relay). |
It's not out yet, is it? Are you on the RC? |
RC 1 doesn't expose the context object, so it wouldn't work. We need to wait for facebook/relay#2547 to land and for the next RC to drop. |
Yeah, I'm on 2.0.0-RC1 in my mobile app. But in the webapp I'm on 1.4. I want to upgrade 1.4 to 2.0. |
V2 was released 2 days ago so probably safe to upgrade now. Is there plans to update this soon? |
nice, i'll work on upgrading |
I've been using this branch for a few days and it seems to do the job: https://github.com/xdissent/found-relay/tree/relay-2 Would you like me to PR to get the ball rolling? It's probably a good time to clean up old stuff (getRequest/getOperation comes to mind) but I didn't go that far. |
oh, that would be great – please do! |
resolved in #167 |
Hi there,
At the time of writing this issue, Relay is on 1.7.0-rc.1, so it is a little early to fix.
I attempted to load up Relay 1.7.0-rc.1 with found-relay, and it is erroring here:
https://github.com/facebook/relay/blob/98e866f5e0fc3548f0577bf081df0507832b15f9/packages/react-relay/modern/buildReactRelayContainer.js#L80
with an error of
.unstable_read
is not a functionI think its because found-relay expects the legacy Context API, while Relay is using the new Context in React 16.
Reference to
Context.unstable_read
: facebook/react#13139Any thoughts?
Though it is possible that its not a problem of found-relay, but its just that the Relay master branch is unstable. I thought it would be related to found-relay because its erroring on components that are used as routes.
The text was updated successfully, but these errors were encountered: