Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Relay v2.0.0 #159

Closed
johntran opened this issue Oct 4, 2018 · 10 comments
Closed

Support Relay v2.0.0 #159

johntran opened this issue Oct 4, 2018 · 10 comments

Comments

@johntran
Copy link

johntran commented Oct 4, 2018

Hi there,

At the time of writing this issue, Relay is on 1.7.0-rc.1, so it is a little early to fix.

I attempted to load up Relay 1.7.0-rc.1 with found-relay, and it is erroring here:

https://github.com/facebook/relay/blob/98e866f5e0fc3548f0577bf081df0507832b15f9/packages/react-relay/modern/buildReactRelayContainer.js#L80

with an error of .unstable_read is not a function

I think its because found-relay expects the legacy Context API, while Relay is using the new Context in React 16.

Reference to Context.unstable_read: facebook/react#13139

Any thoughts?

Though it is possible that its not a problem of found-relay, but its just that the Relay master branch is unstable. I thought it would be related to found-relay because its erroring on components that are used as routes.

@taion
Copy link
Member

taion commented Oct 4, 2018

Yeah, I think we'll need to release a breaking change here to move to the new context API, if Relay 1.7.0 does.

@johntran johntran changed the title Support Relay 1.7.0 Support Relay v2.0.0 Oct 31, 2018
@GrigoryPtashko
Copy link

Are there any plans on Relay 2.0.0 support? I want to upgrade my app to the newest version of Relay (I'm using Found Relay).

@taion
Copy link
Member

taion commented Nov 26, 2018

It's not out yet, is it? Are you on the RC?

@taion
Copy link
Member

taion commented Nov 26, 2018

RC 1 doesn't expose the context object, so it wouldn't work. We need to wait for facebook/relay#2547 to land and for the next RC to drop.

@GrigoryPtashko
Copy link

Yeah, I'm on 2.0.0-RC1 in my mobile app. But in the webapp I'm on 1.4. I want to upgrade 1.4 to 2.0.

@wkerswell-gresham
Copy link

V2 was released 2 days ago so probably safe to upgrade now. Is there plans to update this soon?

@taion
Copy link
Member

taion commented Jan 28, 2019

nice, i'll work on upgrading

@xdissent
Copy link
Contributor

xdissent commented Feb 1, 2019

I've been using this branch for a few days and it seems to do the job: https://github.com/xdissent/found-relay/tree/relay-2 Would you like me to PR to get the ball rolling? It's probably a good time to clean up old stuff (getRequest/getOperation comes to mind) but I didn't go that far.

@taion
Copy link
Member

taion commented Feb 1, 2019

oh, that would be great – please do!

@taion
Copy link
Member

taion commented Feb 5, 2019

resolved in #167

@taion taion closed this as completed Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants