Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🗺 Add lazy property to Route #9884

Closed
4 tasks done
ryanflorence opened this issue Jan 11, 2023 Discussed in #9826 · 4 comments
Closed
4 tasks done

🗺 Add lazy property to Route #9884

ryanflorence opened this issue Jan 11, 2023 Discussed in #9826 · 4 comments
Assignees

Comments

@ryanflorence
Copy link
Member

ryanflorence commented Jan 11, 2023

Don't want to add a new function like createModuleRoutes we just want to add <Route module> and then ignore all the other things.

Progress

@ryanflorence ryanflorence moved this to Backlog in Roadmap Jan 12, 2023
@ryanflorence ryanflorence moved this from Backlog to Planned in Roadmap Jan 24, 2023
@markdalgleish markdalgleish moved this from Planned to In Progress in Roadmap Jan 31, 2023
@ryanflorence
Copy link
Member Author

@markdalgleish get to a happy place and then we'll have a meeting to figure out how much Remix (particularly manifest routes) we want to bring over to React Router.

@ryanflorence ryanflorence changed the title 🗺 Add module property to Route 🗺 Add lazy property to Route Feb 7, 2023
@brophdawg11 brophdawg11 moved this from In Progress to Merged in Roadmap Mar 8, 2023
@brophdawg11
Copy link
Contributor

This is released in react-router-dom@6.9.0-pre.0 if anyone is keeping an eye on this and wants to give it a test spin 😉

@david-crespo
Copy link
Contributor

Tried both the lazy prop and the non-lazy Component prop. Looking good! I could definitely get into a pattern like this for things I don't care about code-splitting.

import * as SSHKeysPage from './pages/settings/SSHKeysPage'

<Route path="ssh-keys" {...SSHKeysPage } />

@brophdawg11 brophdawg11 moved this from Merged to Released in Roadmap Mar 10, 2023
@brophdawg11
Copy link
Contributor

Released in 6.9.0

@github-project-automation github-project-automation bot moved this from Released to Merged in Roadmap Mar 13, 2023
@brophdawg11 brophdawg11 moved this from Merged to Released in Roadmap Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

5 participants