Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-router-dom): fix detectErrorBoundary function #10190

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

vonagam
Copy link
Contributor

@vonagam vonagam commented Mar 11, 2023

Check for presence of new ErrorBoundary property was missing.

@changeset-bot
Copy link

changeset-bot bot commented Mar 11, 2023

🦋 Changeset detected

Latest commit: 63fc751

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
react-router-dom Patch
react-router Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Mar 11, 2023

Hi @vonagam,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@timdorr
Copy link
Member

timdorr commented Mar 11, 2023

Can you add a test for this so we don't have a regression later?

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Mar 11, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@vonagam
Copy link
Contributor Author

vonagam commented Mar 11, 2023

I changed some places in existing tests to use ErrorBoundary. Hope it is ok. Important one is "handles framework agnostic static handler routes", without the change hasErrorBoundary is false.

@MichaelDeBoey MichaelDeBoey changed the title Fix detectErrorBoundary in react-router-dom/server fix(react-router-dom): fix detectErrorBoundary function Mar 11, 2023
@vonagam vonagam force-pushed the fix-error-bounadry-dom-server branch from b9b7c53 to 511840c Compare March 12, 2023 03:21
Copy link
Contributor

@brophdawg11 brophdawg11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @vonagam! Just one comment for the unit test updates

@brophdawg11 brophdawg11 self-assigned this Mar 13, 2023
@vonagam vonagam force-pushed the fix-error-bounadry-dom-server branch from 511840c to 1284fd4 Compare March 13, 2023 18:02
@brophdawg11
Copy link
Contributor

Thanks @vonagam! This looks good - do you mind just rebasing/repointing this to dev since it contains a code change? Then I think we're good to merge 👍

@vonagam vonagam force-pushed the fix-error-bounadry-dom-server branch from 1284fd4 to 63fc751 Compare March 13, 2023 18:17
@vonagam vonagam changed the base branch from main to dev March 13, 2023 18:18
@timdorr
Copy link
Member

timdorr commented Mar 13, 2023

Thanks!

@timdorr timdorr merged commit 0f561ee into remix-run:dev Mar 13, 2023
@vonagam vonagam deleted the fix-error-bounadry-dom-server branch March 13, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants