Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🗺 Alternate submission encodings #10413

Merged
merged 44 commits into from
Jun 8, 2023
Merged

Conversation

brophdawg11
Copy link
Contributor

@brophdawg11 brophdawg11 commented Apr 28, 2023

Updated approach for #10324

Note: inline fetcher loader/action support was removed and this is trimmed to just add json/text encType support. We need to figure out how react form actions impact the submit/fetcher API in this and Remix.

TODO:

  • Remove inline action support on useSubmit (only allowed on fetcher.submit)
  • Ensure encType is limited to browser behavior on <Form>/<fetcher.Form>
  • Update docs to reflect latest APIs

@changeset-bot
Copy link

changeset-bot bot commented Apr 28, 2023

🦋 Changeset detected

Latest commit: e22ec53

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@remix-run/router Minor
react-router-dom Minor
react-router Minor
react-router-dom-v5-compat Minor
react-router-native Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 changed the title Submission encoding and inline actions Alternate submission encodings and inline actions Apr 28, 2023
@brophdawg11 brophdawg11 self-assigned this Apr 28, 2023
@brophdawg11 brophdawg11 marked this pull request as ready for review May 3, 2023 15:20
@brophdawg11 brophdawg11 changed the title Alternate submission encodings and inline actions Alternate submission encodings May 31, 2023
submit({ key: "value" });
// navigation.formEncType => "application/x-www-form-urlencoded"
// navigation.formData => FormData instance
// navigation.text => "key=value"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's consider making text/formData/json all mutually exclusive to avoid buffering large bodies in memory

@brophdawg11 brophdawg11 merged commit c8c417d into dev Jun 8, 2023
@brophdawg11 brophdawg11 deleted the brophdawg11/better-actions branch June 8, 2023 16:27
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.14.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.14.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@MichaelDeBoey MichaelDeBoey changed the title Alternate submission encodings 🗺 Alternate submission encodings Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants