Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove false positive link prefetch warning #12485

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

brophdawg11
Copy link
Contributor

Closes #12439

Copy link

changeset-bot bot commented Dec 6, 2024

🦋 Changeset detected

Latest commit: 0c3f400

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
react-router Patch
@react-router/architect Patch
@react-router/cloudflare Patch
@react-router/dev Patch
react-router-dom Patch
@react-router/express Patch
@react-router/node Patch
@react-router/serve Patch
@react-router/fs-routes Patch
@react-router/remix-routes-option-adapter Patch
create-react-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 linked an issue Dec 6, 2024 that may be closed by this pull request
@@ -279,7 +279,6 @@ export function PrefetchPageLinks({
);

if (!matches) {
console.warn(`Tried to prefetch ${page} but no routes matched.`);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine to remove entirely as if the route doesn't truly exist it'll 404 anyway so there's no real benefit in "hey I cant prefetch anything for this link that won't work anyway".

If we really wanted to keep it, then I think we would need to add some verbiage around the fact that it might print once prior to the route being discovered but then work after discovery completes, which is gross.

@brophdawg11 brophdawg11 merged commit 64e0a03 into dev Dec 6, 2024
5 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/remove-prefetch-warning branch December 6, 2024 17:18
Copy link
Contributor

🤖 Hello there,

We just published version 7.1.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 7.1.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RR 7 can't prefetch link with intent set to viewport
1 participant