Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scroll restoration when redirecting in an action #9815

Merged
merged 5 commits into from
Jan 11, 2023

Conversation

jrakotoharisoa
Copy link
Contributor

This Pull request fix issue #9577

@changeset-bot
Copy link

changeset-bot bot commented Jan 4, 2023

🦋 Changeset detected

Latest commit: 859b093

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@remix-run/router Patch
react-router Patch
react-router-dom Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 self-assigned this Jan 5, 2023
@brophdawg11 brophdawg11 changed the base branch from dev to brophdawg11/action-scroll-restoration January 11, 2023 19:24
@brophdawg11
Copy link
Contributor

Thanks for the PR @jrakotoharisoa! We talked a bit more on this internally and there's a few things we also want to add as part of this so I'm going to merge this into my branch and iterate a bit more on it there 👍

@brophdawg11 brophdawg11 merged commit 72ce65c into remix-run:brophdawg11/action-scroll-restoration Jan 11, 2023
brophdawg11 added a commit that referenced this pull request Jan 11, 2023
* Fix scroll restoration when redirecting in an action (#9815)
* Add preventScrollReset prop to Form

Co-authored-by: Johann R <johann.rakotoharisoa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants