Browser publicPath totally ignored in @remix-run/serve

[fguitton]

Hello,
I hope you are having a great day !
🌴

What version of Remix are you using?

1.4.1

Steps to Reproduce

Create a remix application and set the remix.config.js field publicPath to something other than /build/.
Upon running remix dev and accessing the URL in a browser, assets cannot be found.

Expected Behavior

It should be possible to customize the asset serving path while developing.

Actual Behavior

Currently the publicPath is being ignored and prevents the use of a custom path while developing.
No mention of this limitation is made in the documentation as far as I know.
Behavior is consistent with the hardcoded path in the codebase.

remix/packages/remix-serve/index.ts

Lines 13 to 18 in b1ce044

	app.use(
	"/build",
	express.static("public/build", { immutable: true, maxAge: "1y" })
	);
	app.use(express.static("public", { maxAge: "1h" }));

[samlaycock]

I'm seeing the same problem as well, using the Cloudflare Workers runtime. Seems as though the publicPath value in the Remix config is just not being regarded in the serving of static assets of any runtime.

If the intention of this is to simply support CDN domains for static assets, and I'm not sure if it is or not, the docs really should say so... the presumption is we can use this to add route prefixes to the static URLs to allow for more complex routing scenarios (behind proxies/load balancers etc.)

remix/packages/remix-cloudflare-workers/worker.ts

Lines 63 to 64 in 99fbb99

	let assetpath = build.assets.url.split("/").slice(0, -1).join("/");
	let requestpath = url.pathname.split("/").slice(0, -1).join("/");

[machour]

This have been fixed by #3349