Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix-react): stop scroll on fetchers submission #3165

Closed
wants to merge 2 commits into from

Conversation

matt-kinton
Copy link
Contributor

Closes: #3145

  • Docs
  • Tests

Testing Strategy:

To be honest, I couldn't find any tests for <ScrollRestoration /> and I'm not really sure how I could test it easily.

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented May 11, 2022

Hi @Mattinton,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented May 11, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@matt-kinton matt-kinton changed the title fix(remix-react): stop scroll on fetchers submission (#3145) fix(remix-react): stop scroll on fetchers submission May 11, 2022
@duailibe
Copy link

duailibe commented Oct 3, 2022

I'm applying this patch and it works wonderfully

Hoping this will get merged eventually!

@machour
Copy link
Collaborator

machour commented Jan 22, 2023

useScrollRestoration now lives in react-router-dom.

If this is still needed, could you please re-open a PR in the react-router repository? 🙏🏼

/cc @brophdawg11

@machour machour closed this Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed feat:scroll Issues related to scroll restoration renderer:react
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page scrolled back to the top when redirecting to same the page from useFetcher Form
4 participants