Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make picocli-spring-boot-starter an explicitly declared named JPMS module #1608

Closed
remkop opened this issue Feb 26, 2022 · 5 comments
Closed
Labels
theme: module An issue or change related to JPMS modules type: API 🔌 type: doc 📘
Milestone

Comments

@remkop
Copy link
Owner

remkop commented Feb 26, 2022

Make picocli-spring-boot-starter a named JPMS module with the following module-info:

/**
 * Defines Spring-based implementations of picocli APIs and picocli-based implementations
 * of Spring APIs for integrating picocli with Spring Boot and Spring Boot AutoConfiguration.
 *
 * @since 4.7.0
 */
module info.picocli.spring.boot {
    requires info.picocli;
    requires java.util.logging;

   // TBD: or spring.boot.starter (see #1604)
    requires spring.boot;
    requires spring.boot.autoconfigure;

    exports picocli.spring;
    exports picocli.spring.boot.autoconfigure;
}

The exact dependencies still TBD (see also #1604)

Related to #1298

@remkop remkop added this to the 4.7 milestone Feb 26, 2022
@remkop remkop closed this as completed in ccfcad1 Feb 26, 2022
@remkop remkop changed the title Make picocli-spring-boot-starter a named JPMS module Make picocli-spring-boot-starter an explicitly declared named JPMS module Feb 26, 2022
@obfischer
Copy link

Hi @remkop, the current released jar for the Picocli Spring Boot Starter does not contain the module info class. Is this a bug or do I miss something?

@remkop
Copy link
Owner Author

remkop commented Aug 28, 2024

This is a bug. Can you please create a new ticket for this?

@obfischer
Copy link

@remkop Yes, will to it today

@obfischer
Copy link

@remkop Issue created and linked to this issue.

@remkop
Copy link
Owner Author

remkop commented Aug 28, 2024

Thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: module An issue or change related to JPMS modules type: API 🔌 type: doc 📘
Projects
None yet
Development

No branches or pull requests

2 participants