-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(preset): add codemirror group #11721
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this makes sense, as it's not a monorepo. They also have different releases.
If they are released synchronously and must be updated together, then we use a monorepo group. Otherwise if this is just an opinionated grouping/personal preference then it's best to configure it locally and not add it to Renovate. |
They are not exactly released synchronously but a minor version bump will usually result in an update for all the other packages because they have hard dependencies on each other: For example, if I install So I'm not sure if this should be put in the monorepo group or |
This is not a mono repo and the updates don't need to be grouped. So i think this should be done per use case and not by default in any renovate preset. |
The app can break if the dependencies are not updated together though because deduping is actually necessary sometimes, for example, see codemirror/dev#503 (comment). |
@viceice sounds like they've had enough problems that we could group by default. I'd go with |
ok, so @sachinraja please apply the grouping to like this renovate/lib/config/presets/internal/group.ts Lines 451 to 462 in 050b6a9
|
Head branch was pushed to by a user without write access
🎉 This PR is included in version 27.9.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Added as a pattern group because each package has a separate repository:
https://github.com/codemirror/view
https://github.com/codemirror/state
https://github.com/codemirror/lang-javascript
and so on.