Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert recreateClosed to enum like #17952

Closed
rarkins opened this issue Sep 24, 2022 · 1 comment · Fixed by #21039
Closed

Convert recreateClosed to enum like #17952

rarkins opened this issue Sep 24, 2022 · 1 comment · Fixed by #21039
Assignees
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented Sep 24, 2022

What would you like Renovate to be able to do?

Support values of never, auto and always for recreateClosed. auto maps to the current default false value, and always maps to current true value. The use of never would be for people to say they don't want immortal PRs reopened.

If you have any ideas on how this should be implemented, please tell us here.

Per above

Need to make sure PR description is correct in case of immortal PRs and recreateClosed=never

Is this a feature you are interested in implementing yourself?

No

@rarkins rarkins added type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:ready labels Sep 24, 2022
@RahulGautamSingh
Copy link
Collaborator

Since we have decided to not use enums anymore. I think we will need to convert it to a string type.

type RecreateClosed = 'auto' | 'always' | 'never';

@viceice viceice changed the title Convert recreateClosed to enum Convert recreateClosed to enum like Mar 12, 2023
@RahulGautamSingh RahulGautamSingh self-assigned this Mar 19, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants