Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform): handle unexpected github-graphql error #22512

Merged
merged 5 commits into from
May 31, 2023

Conversation

RahulGautamSingh
Copy link
Collaborator

Changes

There are some graphQL errors that are returned with a 200 status code, eg. RATE_LIMITED. There isn't any official documentation for these errors so we can't be sure if it happens only for rate-limited or not. Therefore, I have added a new error-constant PLATFORM_UNKNOWN_ERROR for such errors.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@RahulGautamSingh RahulGautamSingh requested a review from rarkins May 31, 2023 02:11
lib/constants/error-messages.ts Outdated Show resolved Hide resolved
lib/modules/platform/github/index.spec.ts Outdated Show resolved Hide resolved
lib/modules/platform/github/index.spec.ts Outdated Show resolved Hide resolved
lib/modules/platform/github/index.ts Outdated Show resolved Hide resolved
@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review May 31, 2023 15:46
@RahulGautamSingh RahulGautamSingh requested a review from rarkins May 31, 2023 15:46
@rarkins rarkins added this pull request to the merge queue May 31, 2023
Merged via the queue into renovatebot:main with commit 04f4875 May 31, 2023
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.105.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle rate limit exceeded response for github.initRepo
3 participants