Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(yarn): support corepack constraint #23395

Merged
merged 4 commits into from
Jul 18, 2023

Conversation

dmitriy-kudelko
Copy link
Contributor

Changes

The PR introduces corepack version customization via constraints.coperpack configuration option.

Corepack has recently dropped support of Node.js 14. Some repos however still rely on older Node.js versions because of e.g. dependencies which are still incompatible with newer Node.js versions. This in turn makes impossible using renovate in such repos since it attempts installing latest corepack version by default and fails.

Context

#23389

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be added to lerna too

@dmitriy-kudelko
Copy link
Contributor Author

this needs to be added to lerna too

This is where I may need a little help. I modified the code without covering with test for now, cause I'm not sure if just adding corepack to toolConstraints similarly to yarn would be sufficient.

Shall I request access to Slack channel do discuss this?

@dmitriy-kudelko dmitriy-kudelko requested a review from viceice July 17, 2023 15:49
@viceice viceice added this pull request to the merge queue Jul 18, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 18, 2023
@viceice viceice added this pull request to the merge queue Jul 18, 2023
Merged via the queue into renovatebot:main with commit d9a24c5 Jul 18, 2023
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.9.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants