Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add minimatch wrapper to support caching #23515

Merged
merged 6 commits into from
Jul 24, 2023

Conversation

setchy
Copy link
Collaborator

@setchy setchy commented Jul 22, 2023

Changes

Adds a wrapper for minimatch to support caching

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@setchy setchy marked this pull request as draft July 22, 2023 21:12
@setchy setchy marked this pull request as ready for review July 22, 2023 21:22
@setchy setchy requested review from viceice and rarkins July 22, 2023 21:22
lib/util/minimatch.ts Outdated Show resolved Hide resolved
lib/util/minimatch.spec.ts Outdated Show resolved Hide resolved
@setchy setchy requested a review from viceice July 23, 2023 20:28
@setchy setchy added the type:feature Feature (new functionality) label Jul 23, 2023
@setchy setchy self-assigned this Jul 23, 2023
@viceice viceice added this pull request to the merge queue Jul 24, 2023
@viceice
Copy link
Member

viceice commented Jul 24, 2023

I don't close the issue, as we need to update all minimatch usages first.

we should also blacklist default minimatch module via eslint to not accidentally import the wrong version.

Merged via the queue into renovatebot:main with commit e24ca0e Jul 24, 2023
@setchy setchy deleted the feature/cache-minimatch branch July 24, 2023 20:19
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type:feature Feature (new functionality)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants