Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/azure-pipelines): Deployment jobs support #26048

Merged
merged 19 commits into from
Dec 11, 2023

Conversation

jabbera
Copy link
Contributor

@jabbera jabbera commented Nov 29, 2023

Changes

Azure Devops has the concept of deployment jobs that are not covered by rennovate. This PR adds support for these jobs. I'm open to another approach for testing these changes as the # of fixture has exploded.

Microsoft Docs on Deployment Jobs: https://learn.microsoft.com/en-us/azure/devops/pipelines/process/deployment-jobs?view=azure-devops#runonce-deployment-strategy

Context

Explained above

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@jabbera jabbera changed the title Deplyoment jobs support Azure Devops: Deployment jobs support Nov 29, 2023
@jabbera jabbera changed the title Azure Devops: Deployment jobs support feat(azure-pipelines): Deployment jobs support Nov 29, 2023
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please convert types to zod schema validation

@jabbera jabbera changed the title feat(azure-pipelines): Deployment jobs support feat(manager/azure-pipelines): Deployment jobs support Nov 29, 2023
@jabbera
Copy link
Contributor Author

jabbera commented Nov 30, 2023

please convert types to zod schema validation

This was a rabbit hole. I raised some comments where I made changes and why they were made.

@jabbera jabbera marked this pull request as draft November 30, 2023 03:50
@jabbera jabbera marked this pull request as ready for review November 30, 2023 04:26
@jabbera jabbera marked this pull request as draft November 30, 2023 14:54
@jabbera jabbera marked this pull request as ready for review November 30, 2023 16:31
lib/modules/manager/azure-pipelines/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/azure-pipelines/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/azure-pipelines/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/azure-pipelines/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/azure-pipelines/extract.ts Outdated Show resolved Hide resolved
@jabbera
Copy link
Contributor Author

jabbera commented Dec 5, 2023

Hi. This PR now needs to be rebased. @viceice should I wait until you comment on my above question or rebase now?

rarkins
rarkins previously requested changes Dec 8, 2023
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs de-conflicting

@jabbera
Copy link
Contributor Author

jabbera commented Dec 8, 2023

Needs de-conflicting

All set.

@rarkins rarkins added this pull request to the merge queue Dec 11, 2023
Merged via the queue into renovatebot:main with commit c39aa7e Dec 11, 2023
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.91.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jabbera
Copy link
Contributor Author

jabbera commented Dec 11, 2023

Thanks all!

@jabbera jabbera deleted the deplyoment branch January 4, 2024 18:03
hersentino pushed a commit to hiventive/renovate that referenced this pull request Jan 9, 2024
zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 22, 2024
zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 24, 2024
zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 24, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants