Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manager/conan): allow ref with user only #26516

Merged

Conversation

dazze1812
Copy link
Contributor

@dazze1812 dazze1812 commented Jan 5, 2024

Changes

For Conan package references "user" can be used without specifying a "channel".

Now package/1.2.3@user is also possible.

Context

see #26040

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@CLAassistant
Copy link

CLAassistant commented Jan 5, 2024

CLA assistant check
All committers have signed the CLA.

@viceice viceice changed the title fix(conan): allow Conan ref with user only fix(manager/conan): allow ref with user only Jan 5, 2024
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test on a real repo to ensure the conan datasource can also handle this.

rarkins
rarkins previously approved these changes Jan 5, 2024
@viceice
Copy link
Member

viceice commented Jan 8, 2024

Please test on a real repo to ensure the conan datasource can also handle this.

☝️

@dazze1812
Copy link
Contributor Author

Please test on a real repo to ensure the conan datasource can also handle this.

☝️

Sorry, but I still have no test environment. To test this for our use case I need a test on our local Conan and GitLab infrastructure. Is there a guide line how to setup a local test? I only found the guide line for testing on a public GitHub repo.

@rarkins
Copy link
Collaborator

rarkins commented Jan 9, 2024

Locally you can run with pnpm start .... instead of renovate ..... All other config (e.g. platform, endpoint, token, etc) remain the same

dkoerner-festo and others added 2 commits January 10, 2024 15:37
In Conan 2.x include_prerelease do not have an argument
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@viceice
Copy link
Member

viceice commented Jan 11, 2024

Please test on a real repo to ensure the conan datasource can also handle this.

where did you test this?

@dazze1812
Copy link
Contributor Author

Please test on a real repo to ensure the conan datasource can also handle this.

where did you test this?

We have an internal GitLab and Artifactory installation. The public Conan center packages do not have the user attribute so I needed to test it internally.

@viceice viceice requested a review from rarkins January 15, 2024 08:32
@rarkins rarkins added this pull request to the merge queue Jan 15, 2024
Merged via the queue into renovatebot:main with commit 5a51173 Jan 15, 2024
36 checks passed
@dazze1812 dazze1812 deleted the allow_conan_ref_with_user_only branch January 15, 2024 08:53
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.132.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 22, 2024
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 24, 2024
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 24, 2024
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants