Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(osv): pass GitHub token for DB download #26808

Merged
merged 2 commits into from
Jan 26, 2024
Merged

feat(osv): pass GitHub token for DB download #26808

merged 2 commits into from
Jan 26, 2024

Conversation

jporzucek
Copy link
Contributor

@jporzucek jporzucek commented Jan 22, 2024 •
edited
Loading

Changes

Context

Fixes #24209 There is also an accompanying PR in renovatebot/osv-offline#569

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@CLAassistant
Copy link

CLAassistant commented Jan 22, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jporzucek jporzucek mentioned this pull request Jan 22, 2024
Merged
@jporzucek jporzucek changed the title Add token support for fetching vulnerabilities imporve(osv): add parameter token support Jan 22, 2024
@jporzucek jporzucek changed the title imporve(osv): add parameter token support improve(osv): add parameter token support Jan 22, 2024
viceice
viceice reviewed Jan 22, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs upstream change first

@jporzucek
Copy link
Contributor Author

Hi @viceice, since the upstream has been merged , can you review that one pls?

@viceice
Copy link
Member

viceice commented Jan 24, 2024

Hi @viceice, since the upstream has been merged , can you review that one pls?

checks failed, merged main and make tests successful

viceice

This comment was marked as duplicate.

Sign in to view

viceice
viceice reviewed Jan 26, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import order is wrong, see comment from CI below.

lib/workers/repository/process/vulnerabilities.ts Outdated Show resolved Hide resolved
lib/workers/repository/process/vulnerabilities.ts Show resolved Hide resolved
@viceice viceice changed the title improve(osv): add parameter token support feat(osv): pass GitHub token for DB download Jan 26, 2024
@viceice viceice added this pull request to the merge queue Jan 26, 2024
Merged via the queue into renovatebot:main with commit 16c7b94 Jan 26, 2024
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.153.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@eliashaeussler eliashaeussler mentioned this pull request Jan 29, 2024
Merged
rvanbutselaar pushed a commit to rvanbutselaar/renovate that referenced this pull request Feb 2, 2024
@jporzucek @viceice
feat(osv): pass GitHub token for DB download (renovatebot#26808)
d9cacc0 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@MPV
Copy link
Contributor

MPV commented Feb 9, 2024

Did this cause...?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jporzucek @CLAassistant @viceice @renovate-release @MPV