fix: consider 'defaultBranch' setting when doing git clone #26810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
viceice
previously approved these changes
Jan 23, 2024
secustor
reviewed
Jan 23, 2024
secustor
approved these changes
Jan 23, 2024
|
🎉 This PR is included in version 37.148.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
rvanbutselaar
pushed a commit
to rvanbutselaar/renovate
that referenced
this pull request
Feb 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes the issue where the global config flags
bbUseDevelopmentBranchandbaseBranchesdon't work in a specific case.It manifests as Renovate's inability to find the
renovate.jsonconfig which is available in one of thebaseBranchesor in aDEVELOPMENTbranch on Bitbucket, but not available on main branch which is mistakenly cloned.For our usecase, this happens when onboarding a new repository - we treat our main branch as a "production" branch and don't merge
renovate.jsoninside instantly - due to this bug we are unable to onboard repositories with a development branch in a standardized way.Context
#26805
This is my first contribution to Renovate so please let me know if anything can be further improved.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: