Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(asdf): Add minikube to asdf manager #29189

Merged
merged 2 commits into from
May 22, 2024
Merged

feat(asdf): Add minikube to asdf manager #29189

merged 2 commits into from
May 22, 2024

Conversation

kivra-pauoli
Copy link
Contributor

@kivra-pauoli kivra-pauoli commented May 21, 2024 •
edited
Loading

Changes

This pull request adds support to bumping minikube entries in .tool-versions files, as supported by https://asdf-vm.com/.

Context

minikube is not supported (by Renovate) in .tool-versions files, at this moment.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

viceice
viceice previously approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here we need to remove the v prefix

@viceice viceice enabled auto-merge May 21, 2024 20:35
auto-merge was automatically disabled May 22, 2024 10:23

Head branch was pushed to by a user without write access

@kivra-pauoli
Copy link
Contributor Author

@viceice, had to push a new commit due to a failing test over an extra v. Your approval is thus dismissed automatically.

@viceice viceice added this pull request to the merge queue May 22, 2024
Merged via the queue into renovatebot:main with commit 2525559 May 22, 2024
39 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.373.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kivra-pauoli kivra-pauoli deleted the feat/asdf-minikube branch May 22, 2024 13:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kivra-pauoli @renovate-release @viceice