feat(schedule): Log descriptive cron schedules #30472
Conversation
rarkins
changed the title
test case already written for invalid string types |
|
You had tests before but they're missing now |
|
However, all the scenarios have already been covered in the previous test cases. Additionally, the test cases I added earlier will not run for the function where I made the changes. |
|
We don't add features without tests to verify that the feature works |
…into issue-22267
added please check |
|
🎉 This issue has been resolved in version 38.16.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
| const cronScheduleSummary = cronstrue.toString(scheduleText, { | ||
| throwExceptionOnParseError: false, | ||
| }); | ||
| logger.debug(`Human-readable summary for cron:: ${cronScheduleSummary}`); |
There was a problem hiding this comment.
this causes a weird debug message for all later based strings as we try to parse as cron first 😕
There was a problem hiding this comment.
@rarkins we should refactor to only log if it's a cron expression and not a later expression.
There was a problem hiding this comment.
this message is also logged multiple times (for each branch)
Changes
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: