-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(prettier): show diff if prettier made changes #30798
Conversation
The normal output is not helpful, see also: prettier/prettier#6885
Is there a reason you can not simply run |
Does that show a diff? Or does it push changes back into PR? I'd be fine with either one :) |
This is run locally to fix such issues automatically and should be then commited by the dev. |
It would still be nice if the CI would show me what should be changed, not everyone is ~willing/~able to setup that quite huge development environment :) What do you think about adding a link to the dev-docs if prettier fails? @secustor |
@Finkregh what's the problem you're trying to solve? e.g you submit a PR which has prettier problems, and it fails on CI, and you want more details? I don't object to this, but the "next step" will still be to run |
@rarkins yes, exactly. Make it at least an option to see what the files should look like :) |
Seems ok for me for those who want to contribute via the GitHub UI and not Codespaces or locally. @secustor wdyt? |
Fine by me, though not sure if this will really be that helpful as Github UI messes with whitespace in the Actions UI as far as I know. |
🎉 This issue has been resolved in version 38.41.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
The normal output is not helpful, see also: prettier/prettier#6885
Changes
Linting with prettier now shows a diff if there are changes. This makes it easier to see what changes it actually want (not only the file names as before).
Context
https://github.com/renovatebot/renovate/actions/runs/10395128990/job/28798791562?pr=30680
Output here does not really help.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: