feat(github-action): retain spaces in extracted values #32730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update ensures that Renovate retains the number of whitespaces already present in the GitHub Action YAML file. If there are no existing comments indicating the version number (e.g., when initially pinning a dependency), Renovate's behaviour remains unchanged (that is, it will insert a single space between the commit hash and the `#`). Signed-off-by: JP-Ellis <josh@jpellis.me>
viceice
reviewed
Nov 26, 2024
Co-authored-by: Michael Kriese <michael.kriese@gmx.de>
|
Awesome thanks! All changes incorporated 🚀 |
viceice
previously approved these changes
Nov 28, 2024
|
I see there's a lint issue in CI about a missing comma in the |
rarkins
approved these changes
Nov 28, 2024
Interestingly it needed a |
|
Oh wow, I'm surprised vscode didn't highlight the issue 🤔 Thanks though! |
|
🎉 This PR is included in version 39.38.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ssams
pushed a commit
to ssams/renovate
that referenced
this pull request
Dec 2, 2024
…2730) Signed-off-by: JP-Ellis <josh@jpellis.me> Co-authored-by: Michael Kriese <michael.kriese@gmx.de> Co-authored-by: Rhys Arkins <rhys@arkins.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This update ensures that Renovate retains the number of whitespaces already present in the GitHub Action YAML file.
If there are no existing comments indicating the version number (e.g., when initially pinning a dependency), Renovate's behaviour remains unchanged (that is, it will insert a single space between the commit hash and the
#).Context
Documentation (please check one with an [x])
Note
I do not believe this requires a documentation update as it is a rather transparent feature, but please let me know otherwise.
The GitHub Actions docs do contain a link to the above ticket that will be closed.
How I've tested my work (please select one)
I have verified these changes via: