fix(bundler): fix inline source variable parsing #32946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Djiit
commented
Dec 6, 2024
viceice
reviewed
Dec 6, 2024
rarkins
approved these changes
Dec 7, 2024
|
🎉 This PR is included in version 39.57.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
viceice
approved these changes
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Improve ineline source variable parsing. Before this change, renovate was wrongly capturing basically every character after
source:.Context
Original implementation was missing a test. We had, as users, this use case in our codebase, and decided to propose a fix.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: