Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http.createClient is deprecated #382

Closed
thesmart opened this issue Nov 30, 2012 · 4 comments
Closed

http.createClient is deprecated #382

thesmart opened this issue Nov 30, 2012 · 4 comments

Comments

@thesmart
Copy link

With v1.2.0, I'm getting:

http.createClient is deprecated. Use http.request instead.

@thesmart
Copy link
Author

Ah, for some reason default npm is installing v1.2.0? Changed my package.json to explicitly request v2.12.0

@mikeal
Copy link
Member

mikeal commented Nov 30, 2012

wow, why is npm installing a version so old? @isaacs

@isaacs
Copy link
Contributor

isaacs commented Nov 30, 2012

@mikeal Without seeing the log output, and knowing what version of npm and node @thesmart is using, or what his package.json says, I have no way of knowing.

@thesmart
Copy link
Author

thesmart commented Dec 1, 2012

Hmm, the issue no longer repros. Now when I install without a version number, I get the right one.

I pulled from my console logs this output:

Smarts-MacBook-Pro:node-MessageBus smart$ rm -rf node_modules
Smarts-MacBook-Pro:node-MessageBus smart$ npm install request
npm http GET https://registry.npmjs.org/request/1.2.0
npm http 200 https://registry.npmjs.org/request/1.2.0
npm http GET https://registry.npmjs.org/request/-/request-1.2.0.tgz
npm http 200 https://registry.npmjs.org/request/-/request-1.2.0.tgz
request@1.2.0 node_modules/request

Now when I run, I get the latest:

Smarts-MacBook-Pro:node-MessageBus smart$ npm install request
npm http GET https://registry.npmjs.org/request
npm http 200 https://registry.npmjs.org/request
request@2.12.0 node_modules/request

Maybe my package.json was screwed up? Sorry fellas. 🎱

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants