Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new datatypes causes CI failures for cpp doc links in linkinator #4382

Closed
jleibs opened this issue Nov 29, 2023 · 2 comments
Closed
Assignees
Labels
🪳 bug Something isn't working 🧑‍💻 dev experience developer experience (excluding CI)

Comments

@jleibs
Copy link
Member

jleibs commented Nov 29, 2023

See: #4311

Failure here: https://github.com/rerun-io/rerun/actions/runs/7025830274/job/19117413595?pr=4311

Not sure why this isn't a problem with the python or rust doc-links.

@jleibs jleibs added 🪳 bug Something isn't working 👀 needs triage This issue needs to be triaged by the Rerun team 🧑‍💻 dev experience developer experience (excluding CI) and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Nov 29, 2023
@Wumpf Wumpf self-assigned this Nov 29, 2023
@Wumpf
Copy link
Member

Wumpf commented Nov 29, 2023

It actually affects C++ and Rust if you look closely. You're supposed to use the attr.docs.unreleased on new components to avoid this

 Error: Detected 5 broken links.
 docs/content/reference/types/datatypes/uuid.md
   [404] docs/content/reference/types/blueprint/space_view_component.md
   [404] https://ref.rerun.io/docs/cpp/stable/structrerun_1_1datatypes_1_1Uuid.html
   [404] https://docs.rs/rerun/latest/rerun/datatypes/struct.Uuid.html
 docs/content/reference/types/datatypes/entity_path.md
   [404] https://ref.rerun.io/docs/cpp/stable/structrerun_1_1datatypes_1_1EntityPath.html
   [404] https://docs.rs/rerun/latest/rerun/datatypes/struct.EntityPath.html

The only remaining question is why does it not affect Python

@Wumpf
Copy link
Member

Wumpf commented Nov 29, 2023

ah that's because linkinator fails to check broken ankors -the page itself is already there https://ref.rerun.io/docs/python/stable/common/datatypes#rerun.datatypes.Uuid

@Wumpf Wumpf closed this as completed Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 🧑‍💻 dev experience developer experience (excluding CI)
Projects
None yet
Development

No branches or pull requests

2 participants