Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline file & file contents loading behind a trait + registry #4495

Closed
11 tasks done
teh-cmc opened this issue Dec 12, 2023 · 1 comment
Closed
11 tasks done

Streamline file & file contents loading behind a trait + registry #4495

teh-cmc opened this issue Dec 12, 2023 · 1 comment
Assignees
@teh-cmc
Labels
enhancement New feature or request 📺 re_viewer affects re_viewer itself
Milestone
0.12

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Dec 12, 2023 •
edited
Loading

  • Everything (rrd, images, meshes...) should be loaded through the same trait (a DataLoader, if you will)
  • Anybody/anything should be able to register DataLoaders from anywhere
  • That trait should work in any circumstances:
    • Loading files and directories on native:
      • CLI
      • Drag and drop
      • Open menu
    • Loading files and directories on web:
      • CLI
      • Drag and drop
      • Open menu
@teh-cmc teh-cmc added enhancement New feature or request 📺 re_viewer affects re_viewer itself labels Dec 12, 2023
@teh-cmc teh-cmc changed the title Streamline file & file contents behind a trait + registry Streamline file & file contents loading behind a trait + registry Dec 12, 2023
@teh-cmc teh-cmc mentioned this issue Dec 12, 2023
Closed
@teh-cmc teh-cmc self-assigned this Dec 12, 2023
@teh-cmc teh-cmc mentioned this issue Dec 12, 2023
Closed
@teh-cmc teh-cmc added this to the 0.12 milestone Dec 12, 2023
@teh-cmc
Copy link
Member Author

teh-cmc commented Dec 17, 2023

Fixed at some point in the DataLoader PR series:

@teh-cmc teh-cmc closed this as completed Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teh-cmc teh-cmc

Labels
enhancement New feature or request 📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
0.12
Development

No branches or pull requests
1 participant
@teh-cmc