Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync egui_plot item visibility with entity visibility #4974

Open
Tracked by #4813
Wumpf opened this issue Jan 30, 2024 · 0 comments
Open
Tracked by #4813

Sync egui_plot item visibility with entity visibility #4974

Wumpf opened this issue Jan 30, 2024 · 0 comments
Labels
egui Requires egui/eframe work 📺 re_viewer affects re_viewer itself ui concerns graphical user interface
Milestone

Comments

@Wumpf
Copy link
Member

Wumpf commented Jan 30, 2024

Annoyingly there's two types of visibility right now in the plot: egui_plot "hidden item" (PlotMemory::hidden_items) and our regular visibility flag. The former is set by clicking on the legend in egui_plot, the later via our regular api.

To clean this up the hidden items need to be accessible in egui plot. Note that my last change on egui plots here

actually made this a bit of a mess now: This change introduces ids that can be optionally set, but internally plot items are uniquely identified by name! We should use the id everywhere but automatically derive it from the name if not specified otherwise.

@Wumpf Wumpf added other Generated by the "Other" issue template 👀 needs triage This issue needs to be triaged by the Rerun team ui concerns graphical user interface 📺 re_viewer affects re_viewer itself egui Requires egui/eframe work and removed other Generated by the "Other" issue template 👀 needs triage This issue needs to be triaged by the Rerun team labels Jan 30, 2024
@Wumpf Wumpf added this to the 0.13 milestone Jan 30, 2024
@nikolausWest nikolausWest modified the milestones: 0.13, Triage Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
egui Requires egui/eframe work 📺 re_viewer affects re_viewer itself ui concerns graphical user interface
Projects
None yet
Development

No branches or pull requests

2 participants