Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send currently opened app & recording ID to data-loaders #5350

Open
teh-cmc opened this issue Feb 29, 2024 · 0 comments
Open

Send currently opened app & recording ID to data-loaders #5350

teh-cmc opened this issue Feb 29, 2024 · 0 comments
Labels
enhancement New feature or request 📺 re_viewer affects re_viewer itself

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Feb 29, 2024

So they can decide to either append to the currently opened recording or create a new one when e.g. drag-n-dropping.
@teh-cmc teh-cmc added enhancement New feature or request 📺 re_viewer affects re_viewer itself labels Feb 29, 2024
@teh-cmc teh-cmc mentioned this issue Feb 29, 2024
Merged
8 tasks
teh-cmc added a commit that referenced this issue Feb 29, 2024
@teh-cmc
SDK DataLoaders 5: customizable (external) loaders for Rust (#5351)
9e3ffc2 
Adds new `RecommendedLoadSettings` that gets passed to all `DataLoader`s
-- builtin and external -- in order to customize their behaviors.

This includes:
- A recommended recording ID
- The ID of the currently opened recording in the viewer (not
implemented)
  - Related: #5350
- A recommended entity path prefix
- A recommended timepoint

```bash
cargo r -p rerun-loader-rust-file -- run_wasm/src/main.rs  --recording-id this-one --entity-path-prefix a/b/c  --time sim_time=1000 --time wall_time=1709204046 --sequence sim_frame=42 | rerun -
```

![image](https://github.com/rerun-io/rerun/assets/2910679/631d9798-c198-4e86-b6f8-32d0b849e7b2)


Checks:
- [x] external loader ran manually (`loader | rerun`)
- [x] external loader via rerun (`rerun xxx.rs`)
- [x] log_file with external loader (`log_file xxx.rs`)

---

Part of series of PR to expose configurable `DataLoader`s to our SDKs:
- #5327 
- #5328 
- #5330
- #5337
- #5351
- #5355
@teh-cmc teh-cmc changed the title Send currently opened recording ID to data-loaders Send currently opened app & recording ID to data-loaders Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request 📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@teh-cmc