Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallize Space View system evaluation #4460

Merged
merged 12 commits into from
Dec 11, 2023
Merged

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Dec 7, 2023

What

Two levels of parallism actually:

  • All context & part systems for a single space view each run in parallel
  • All space views now in parallel first setup their query and then kick of their (parallized!) system execution

This gives us major speedups whenever:

  • There is several heavy systems in a scene (e.g. a lot of points and a lot of arrows)
  • There is several space views

As such this is a very fundamental & widely applicable parallelization!

image
(a rather silly "points with arrows" scene duplicated a bunch of times. Note that we still don't have any caching, so all these space views might as well be animated individually!)

image (busy rayon worker threads!)

Related things that are not parallel yet:

  • ui methods per space view (run one by one)
  • draw call recording (done as part of the ui method, but we could likely do this in parallel, only joining on these tasks when egui wants to queue up the command buffers)
  • processing within a system depends on the system at hand. Today, only point cloud has some parallization

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
    • Full build: app.rerun.io
    • Partial build: app.rerun.io - Useful for quick testing when changes do not affect examples in any way
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

End of a series on refactors leading to this parallization:

@Wumpf Wumpf added 📺 re_viewer affects re_viewer itself 📉 performance Optimization, memory use, etc include in changelog labels Dec 7, 2023
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wonderful ⭐⭐⭐

I pushed a few commits to improve the puffin profiler output slightly, PTAL

@Wumpf
Copy link
Member Author

Wumpf commented Dec 11, 2023

thanks for those commits, much nicer!

@Wumpf Wumpf merged commit ea4dff1 into main Dec 11, 2023
40 of 41 checks passed
@Wumpf Wumpf deleted the andreas/parallize-space-view-systems branch December 11, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog 📉 performance Optimization, memory use, etc 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parallelize space views
2 participants