From daf7f90c1f9220cab5dc9c4c7f4557e4a8e4d671 Mon Sep 17 00:00:00 2001 From: Cristiano Calcagno Date: Mon, 5 Sep 2022 18:15:25 +0200 Subject: [PATCH 1/2] Fix issue with logging not in debug mode. Fixes https://github.com/rescript-lang/rescript-vscode/issues/574 --- analysis/reanalyze/src/Paths.ml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/analysis/reanalyze/src/Paths.ml b/analysis/reanalyze/src/Paths.ml index 5dd5aad27..b0d64694b 100644 --- a/analysis/reanalyze/src/Paths.ml +++ b/analysis/reanalyze/src/Paths.ml @@ -181,7 +181,8 @@ let readSourceDirs ~configSources = else readDirs json | None -> () else ( - Log_.item "Warning: can't find source dirs: %s\n" sourceDirs; - Log_.item "Types for cross-references will not be found by genType.\n"; + if !Cli.debug then ( + Log_.item "Warning: can't find source dirs: %s\n" sourceDirs; + Log_.item "Types for cross-references will not be found.\n"); dirs := readDirsFromConfig ~configSources); !dirs From c04eb6d070ce061dd552070838e1f7957b5ffdd2 Mon Sep 17 00:00:00 2001 From: Cristiano Calcagno Date: Mon, 5 Sep 2022 18:17:46 +0200 Subject: [PATCH 2/2] Update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 235239f21..376a81c30 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -23,6 +23,7 @@ #### :bug: Bug Fix +- Fix issue where debug output would end up in the JSON file produced by Reanalyze https://github.com/rescript-lang/rescript-vscode/pull/575 - Fix issue where autocomplete would not perform type instantiation https://github.com/rescript-lang/rescript-vscode/pull/561 - Fix issue where hovering over a field in record construction would show the type without instantiating its type arguments https://github.com/rescript-lang/rescript-vscode/pull/560 - Fix Incorrect semantic highlighting of `external` declarations https://github.com/rescript-lang/rescript-vscode/pull/517