Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSocket header authentication #249

Closed
jirenius opened this issue Jun 11, 2024 · 1 comment
Closed

WebSocket header authentication #249

jirenius opened this issue Jun 11, 2024 · 1 comment

Comments

@jirenius
Copy link
Collaborator

jirenius commented Jun 11, 2024

Issue

The headerAuth configuration (or --headauth flag) is currently only used on HTTP calls, and ignored for WebSocket.
It should be possible to configure resgate to also use the header authentication resource for new WebSocket connection.

Notes

To prevent breaking existing deployments of resgate, the feature should not be activated by default.
It should be added as a new setting:

// Header authentication resource method for websocket connections.
// Prior to responding to a websocket connection, this resource method will be
// called, allowing an auth service to set a token using
// information such as the request headers.
// Missing value or null will disable websocket header authentication.
// Eg. "authService.headerLogin"
"wsHeaderAuth": null,
Option Description Default value
-t, --wsheadauth <method> Resource method for WebSocket header authentication
jirenius added a commit that referenced this issue Jun 11, 2024
jirenius added a commit that referenced this issue Jun 12, 2024
…r-authentication

Feature/gh 249 websocket header authentication
@jirenius
Copy link
Collaborator Author

Resolved in PR #250

jirenius added a commit that referenced this issue Jun 30, 2024
Updated TestVersionMatchesTag test to use GITHUB_REF environment variable.
jirenius added a commit that referenced this issue Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant