Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of TRestAxionOpticsMirror to get reflectivity from Henke database #22

Merged
merged 40 commits into from
Apr 22, 2022

Conversation

jgalan
Copy link
Member

@jgalan jgalan commented Apr 4, 2022

jgalan Large: 949

It implements the class TRestAxionOpticsMirror.

out-4

Few methods were upgraded to be used in this PR at rest-for-physics/framework#175

@jgalan
Copy link
Member Author

jgalan commented Apr 7, 2022

Ups! I guess I have to translate the comment ...
This is great! We have an XXM mirror defined in terms of reflectivity 👍
I think it would be better in linear scale from 0 to 1 with 0.1 intervals, so that we can directly interprete is as 10%,20% ... 100%. But this might be a matter of taste or default.
Ole, ole!

In principle you may recover the canvas in the return of the DrawOpticsProperties function. And you may personalize the aesthetics. Such as changing linear/log scale, or the ranges.

If you draw the canvas in an interactive restRoot session, then you will also be able to inter actuate with the plot. I guess 100% 90% 80% would be interesting because 10-5 reflectivity is basically 0 for us.

Perhaps we could have both easily if needed.

@jgalan
Copy link
Member Author

jgalan commented Apr 7, 2022

Bilayer reflectivity has also been implemented.

bilayer

@jgalan jgalan merged commit b96d3e6 into master Apr 22, 2022
@jgalan jgalan deleted the jgalan_mirror branch April 22, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants