Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending InitFromConfigFile scheme used in REST processes to any metadata class #142

Closed
jgalan opened this issue Feb 22, 2022 · 1 comment · Fixed by #143
Closed

Extending InitFromConfigFile scheme used in REST processes to any metadata class #142

jgalan opened this issue Feb 22, 2022 · 1 comment · Fixed by #143
Assignees
Labels
enhancement New feature or request

Comments

@jgalan
Copy link
Member

jgalan commented Feb 22, 2022

I wonder if we could extend the nice system we have inside TRestEventProcess to TRestMetadata (i.e. avoiding re-implementation of InitFromConfigFile for simple parameters).

I thought it could be as simple as implementing TRestMetadata method,

    virtual void InitFromConfigFile() {
        map<string, string> parameters = GetParametersList();

        for (auto& p : parameters) p.second = ReplaceMathematicalExpressions(p.second);

        ReadParametersList(parameters);
    }

however, I run into troubles.

Any quick solution to extend the processes InitFromConfigFile strategy to any metadata class?

@jgalan jgalan added the enhancement New feature or request label Feb 22, 2022
@jgalan jgalan linked a pull request Feb 22, 2022 that will close this issue
@jgalan
Copy link
Member Author

jgalan commented Feb 22, 2022

Ok, probably I solved my problems. I created a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants