Renamed method to check if file is accessible (CheckFileIsAccessible)
#248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dependencies` to fix restG4 pipeline
juanangp
approved these changes
Jun 13, 2022
lobis
changed the title
CheckFileIsAccessible)
|
Do you understand why the pipeline is failing? I guess due to the changes on rest-for-physics/restG4#52 |
don't think so since rest-for-physics/restG4#51 was merged afterwards, probably this is the cause, but I think these changes should pass the pipeline |
|
The problems in the pipeline are due to changes to the validation files implemented in rest-for-physics/restG4#51, my bad :( I will make a PR to fix this, but this PR can be safely merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the code originally presented in #239.
It contains minor changes and a renamed method
CheckFileIsAccessibleand some minor formatting.Method is added at e44b616.