Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed using namespace std from header files and fix errors #50

Merged
merged 2 commits into from
Mar 28, 2022

Conversation

lobis
Copy link
Member

@lobis lobis commented Mar 27, 2022

Large lobis 378

Needed for rest-for-physics/framework#168. Read PR for additional info.

@lobis lobis requested a review from jgalan March 28, 2022 08:46
@lobis
Copy link
Member Author

lobis commented Mar 28, 2022

I will merge this PR to fix problems in pipeline (rest-for-physics/framework#168 (comment)) but the issue with the pipeline is somewhere else, probably with the pull-submodules.py script.

@lobis lobis merged commit d08c8fa into master Mar 28, 2022
@jgalan
Copy link
Member

jgalan commented Mar 28, 2022

Ok, you should delete this branch so that the version at master is pulled.

@nkx111 nkx111 deleted the lobis-remove-namespace-std-from-headers branch March 28, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants