-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rounding AddPoint input #95
Conversation
…o new proper rounding implementation.
@lobis plz, explain how do we solve the pre-commit fail here |
I tested to do a dummy commit as follows:
|
Looks like the whole pipeline from framework is triggered in the libraries, including the pre-commit for framework, but for some reason is not finding the configuration file (which should exist in the framework root directory...). Anyways it looks like the I will also make a separate PR in each submodule to introduce pre-commit by using the configuration present in the framework repository. Edit: This is now ready rest-for-physics/framework#373. |
So, finally I do not see the pre-commit validation check here @lobis @Andrii01L finally the pipelines are succeeding, your update is finally in to master now. |
There needs to be a separate pr for each submodule for this to work (I just did it in restG4) |
Fixes # out[i] rounded when added to the output RawSignal in the RawSignalEvent
Pipeline requires rest-for-physics/framework#370