Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rounding AddPoint input #95

Merged
merged 2 commits into from
Feb 10, 2023
Merged

Rounding AddPoint input #95

merged 2 commits into from
Feb 10, 2023

Conversation

Andrii01L
Copy link
Contributor

@Andrii01L Andrii01L commented Jan 27, 2023

Andrii01L Ok: 9

Fixes # out[i] rounded when added to the output RawSignal in the RawSignalEvent

Pipeline requires rest-for-physics/framework#370

@jgalan jgalan self-requested a review January 27, 2023 21:20
@jgalan
Copy link
Member

jgalan commented Feb 10, 2023

@lobis plz, explain how do we solve the pre-commit fail here

@jgalan
Copy link
Member

jgalan commented Feb 10, 2023

I tested to do a dummy commit as follows:

jgalan@sultan2:~/rest-framework/source/libraries/raw$ git commit -m "TRestRawSignalGeneralFitProcess. Minor doc update to test pre-commit"
Begin formatting!
/usr/bin/clang-format
/usr/bin/xmllint
Formatting file "/home/jgalan/rest-framework/source/libraries/raw/src/TRestRawSignalGeneralFitProcess.cxx"
clang-format -i /home/jgalan/rest-framework/source/libraries/raw/src/TRestRawSignalGeneralFitProcess.cxx
No .pre-commit-config.yaml file was found
- To temporarily silence this, run `PRE_COMMIT_ALLOW_NO_CONFIG=1 git ...`
- To permanently silence this, install pre-commit with the --allow-missing-config option
- To uninstall pre-commit run `pre-commit uninstall`

@lobis
Copy link
Member

lobis commented Feb 10, 2023

@lobis plz, explain how do we solve the pre-commit fail here

Looks like the whole pipeline from framework is triggered in the libraries, including the pre-commit for framework, but for some reason is not finding the configuration file (which should exist in the framework root directory...). Anyways it looks like the pre-commit step in the workflow is redundant since this is already run outside of github actions (see the different logo in the check list), so I will remove it in a PR to framework and everything should work.

I will also make a separate PR in each submodule to introduce pre-commit by using the configuration present in the framework repository.

Edit: This is now ready rest-for-physics/framework#373.

@jgalan
Copy link
Member

jgalan commented Feb 10, 2023

So, finally I do not see the pre-commit validation check here @lobis

@Andrii01L finally the pipelines are succeeding, your update is finally in to master now.

@jgalan jgalan merged commit 4ab6c30 into master Feb 10, 2023
@jgalan jgalan deleted the Andrii01L-patch-1 branch February 10, 2023 14:06
@lobis
Copy link
Member

lobis commented Feb 10, 2023

So, finally I do not see the pre-commit validation check here @lobis

@Andrii01L finally the pipelines are succeeding, your update is finally in to master now.

There needs to be a separate pr for each submodule for this to work (I just did it in restG4)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants