Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue on DetectorConstructor? #90

Closed
jgalan opened this issue Dec 13, 2022 · 1 comment · Fixed by #89 or #91
Closed

Issue on DetectorConstructor? #90

jgalan opened this issue Dec 13, 2022 · 1 comment · Fixed by #89 or #91
Assignees

Comments

@jgalan
Copy link
Member

jgalan commented Dec 13, 2022

In the following piece of code

                for (const auto& logicalVolumeName : logicalVolumes) {
                    auto logicalVolumeRegex =
                        G4LogicalVolumeStore::GetInstance()->GetVolume(logicalVolumeName.Data(), false);
                    logicalVolumesSelected.insert(logicalVolume);
                }

logicalVolumeRegex is not being used. There is perhaps an issue?

@jgalan jgalan linked a pull request Dec 13, 2022 that will close this issue
@jgalan
Copy link
Member Author

jgalan commented Dec 13, 2022

Fixed on #89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants