Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low energy EM updates and bug fix #63

Merged
merged 7 commits into from
Aug 29, 2022
Merged

Low energy EM updates and bug fix #63

merged 7 commits into from
Aug 29, 2022

Conversation

lobis
Copy link
Member

@lobis lobis commented Aug 1, 2022

lobis Medium: 135

This PR fixes the following bug: physics lists options were not being read. Options such as "ARM" of DecayPhysics were not working.

Updates to low energy physics: Previously some options were enabled by default:

UI->ApplyCommand("/process/em/fluo true");
UI->ApplyCommand("/process/em/auger true");
UI->ApplyCommand("/process/em/pixe true");

I found out the option pixe is responsible for a significant increase of simulation time in latest versions of Geant4, due to a lot of very low energy e- being produced. (this is the cause why the 08.Alphas example runs so slow in the pipeline).

The changes in this PR make possible for the user to specify these 3 options as options in the EM physics list. For example:

<physicsList name="G4EmStandardPhysics_option4">
    <option name="pixe" value="true"/>
    <option name="auger" value="false"/>
    <option name="fluo" value="false"/>
</physicsList>

The default value for options fluo and auger is left as true, so the behaviour is the same as previously if not changed. However the option pixe new default value is false, in order to reduce simulation time.

I have modified examples to explictly enabled pixe in order not to modify the validation scripts, however they will be mofied in the future in order to speed them up.

@lobis lobis requested review from juanangp and jgalan and removed request for juanangp August 1, 2022 15:22
@lobis lobis marked this pull request as ready for review August 1, 2022 15:22
@lobis lobis merged commit de9dcc7 into master Aug 29, 2022
@lobis lobis deleted the lobis-physics-low-energy branch August 29, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants