Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use constants from TRestPhysics #2

Open
juanangp opened this issue Nov 17, 2022 · 2 comments
Open

Use constants from TRestPhysics #2

juanangp opened this issue Nov 17, 2022 · 2 comments
Assignees
@jgalan @juanangp @AlvaroEzq

Comments

@juanangp
Copy link
Member

Migrate to TRestPhysics constants, currently wimplib has different units than REST, so there are two options:

  • Migrate to REST units
  • Define wimplib units based on REST units.

Related to #1
@jgalan
Copy link
Member

jgalan commented Nov 17, 2022

It is a matter of units, or it is a matter of constants? It is true than in TRestPhysics there is a units problem because we are not using there the default units as defined by TRestSystemOfUnits.

@juanangp
Copy link
Member Author

I think it is a matter of units because e.g. we use km/s for the speed and GeV for the WIMP mass.

On the other hand, I think the constants in general should use RESTUnits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgalan jgalan

@juanangp juanangp

@AlvaroEzq AlvaroEzq

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jgalan @juanangp @AlvaroEzq