Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging output #289

Closed
4 of 5 tasks
tillrohrmann opened this issue Apr 17, 2023 · 5 comments
Closed
4 of 5 tasks

Improve logging output #289

tillrohrmann opened this issue Apr 17, 2023 · 5 comments
Milestone

Comments

@tillrohrmann
Copy link
Contributor

tillrohrmann commented Apr 17, 2023

We should revisit what the runtime logs on the various log levels to make sure that it gives enough information to the user and that the information makes sense.

Tasks

Preview Give feedback
@tillrohrmann tillrohrmann added this to the 1A milestone Apr 17, 2023
@slinkydeveloper
Copy link
Contributor

slinkydeveloper commented Apr 17, 2023

One thing related to logging that annoys me is that i cannot easily filter restate logs at verbose level compared to other logs. We need to check how we can have something like a restate prefix on all the logs we generate from our code, in order to allow define log filters such as RUST_LOG=info,restate=debug. Perhaps this might simply boil down to adding a prefix to all our modules (which is something we wanted to do anyway)?

@slinkydeveloper
Copy link
Contributor

slinkydeveloper commented Apr 17, 2023

Just tried this RUST_LOG=info,hy=debug and apparently it catches all the hyper logs, and filters out the restate logs lower than info. I guess by naming all our crates with the prefix restate_ we can simply configure logging with RUST_LOG=info,restate=debug

@tillrohrmann
Copy link
Contributor Author

Interesting @slinkydeveloper observation. Yet another reason for prefixing our crates with restate.

@slinkydeveloper
Copy link
Contributor

@tillrohrmann #295

@tillrohrmann
Copy link
Contributor Author

Close as done for M1A.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants