init: Add --copy-chunker-parameters option
#2928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rawtaz
reviewed
Sep 19, 2020
MichaelEischer
force-pushed
the
init-copy-chunker
branch
from
d310acf to
a37e9f7
Compare
MichaelEischer
changed the title
--copy-chunker-parameters option
MichaelEischer
force-pushed
the
init-copy-chunker
branch
from
a37e9f7 to
270b82c
Compare
rawtaz
reviewed
Sep 19, 2020
MichaelEischer
force-pushed
the
init-copy-chunker
branch
4 times, most recently
from
e9b754b to
0e65b29
Compare
This allows creating multiple repositories with identical chunker parameters which is required for working deduplication when copying snapshots between different repositories.
MichaelEischer
force-pushed
the
init-copy-chunker
branch
from
0e65b29 to
f003410
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
It adds a
--copy-chunker-parametersoption to the init command to support copying the chunker parameters to a new repository.This allows creating multiple repositories with identical chunker parameters which is required for working deduplication when copying snapshots between different repositories. See the documentation change for more details.
Was the change discussed in an issue or in the forum before?
The problem was discussed in #2606 but not this solution.
Checklist
[ ] There's a new file inchangelog/unreleased/that describes the changes for our users (template here)gofmton the code in all commits