key: Check that new key works before deleting the old one #3429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelEischer
added a commit
to MichaelEischer/restic
that referenced
this pull request
Aug 16, 2021
This was referenced Aug 16, 2021
mfrischknecht
pushed a commit
to mfrischknecht/restic
that referenced
this pull request
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
When adding a new key or changing the password of a key, restic currently just creates the new key (and removes the old one, when changing the password). There's no verification that the new key works for sure. It could be possible that a random error breaks the new key or that it is not stored properly.
This PR adds a check that the new key actually works before continuing.
Was the change discussed in an issue or in the forum before?
Not really, I've mentioned the idea in #2323.
Checklist
[ ] I have added documentation for the changes (in the manual)changelog/unreleased/that describes the changes for our users (template here)gofmton the code in all commits