Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SAS authentication option for Azure repos #3661

Merged
merged 2 commits into from
Jul 23, 2022

Conversation

rgammans
Copy link
Contributor

@rgammans rgammans commented Mar 5, 2022

What does this PR change? What problem does it solve?

This PR adds the ability to use Azure SAS tokens for authentication. This feature is requested in #2295

This change adds an additional string value to the azure configuration struct to store the SAS, and a separate path to create the service client.

Was the change previously discussed in an issue or on the forum?

Fixes: #2295

Checklist

  • I have read the contribution guidelines.
  • I have enabled maintainer edits.
  • I have added tests for all code changes.
  • I have added documentation for relevant changes (in the manual).
  • [ x] There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
  • I have run gofmt on the code in all commits.
  • All commit messages are formatted in the same style as the other commits in the repo.
  • I'm done! This pull request is ready for review.

I haven't coded any tests as they will require an update to the testing infrastructure to create SAS TOKEN, (although that should be a relatively straightforward change in the workflow). Functionally they should do the same as the existing tests but with a SAS token provided instead of ACCOUNT_KEY.

NB: I'm a relative newbie in Go so there may be some style issues.

Copy link
Member

@MichaelEischer MichaelEischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I've rebased the PR, squashed the commits, fixed the merge conflict, fixed a few typos and added a commit to automatically strip a leading ? from the SAS token.

@MichaelEischer MichaelEischer merged commit 827ab02 into restic:master Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Azure SAS (Shared Access Signatures)
2 participants