add SAS authentication option for Azure repos #3661
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
This PR adds the ability to use Azure SAS tokens for authentication. This feature is requested in #2295
This change adds an additional string value to the azure configuration struct to store the SAS, and a separate path to create the service client.
Was the change previously discussed in an issue or on the forum?
Fixes: #2295
Checklist
changelog/unreleased/
that describes the changes for our users (see template).gofmt
on the code in all commits.I haven't coded any tests as they will require an update to the testing infrastructure to create SAS TOKEN, (although that should be a relatively straightforward change in the workflow). Functionally they should do the same as the existing tests but with a SAS token provided instead of ACCOUNT_KEY.
NB: I'm a relative newbie in Go so there may be some style issues.