keep aspect ratio for thumb

[eworm-de]

I use to run this command to capture the screen, including a thumb:

scrot --thumb 100x0 /tmp/screen.png

The thumb used to have a width of 100 pixels, preserving the correct aspect ration. This broke with ff88b0b (I think, to be verified...) and returns an error message now:

scrot: option --thumb: resolution height '0' is too small

Can we define a special case for value 0 and have the old behavior back?

[guijan]

I've just tried the example invocation with both commit ff88b0b and the preceding ae4deba, and indeed, the change in behavior was introduced by ff88b0b.

[eworm-de]

Will you take care of this or should I have a look myself?

[guijan]

Yes, I'll fix it.

I'm about to go to sleep but I'll be adding this feature back and documenting it (it was undocumented), hopefully there will be a PR today.

Did you find out about it by reading the source code?

[eworm-de]

Found out what, that it works or that it breaks? 😜

Other tools support this or something similar, for example imagemagick:
https://imagemagick.org/script/command-line-processing.php#geometry

So I did just try and it worked.

Well, now it broke. 😝

[daltomi]

Too bad, I did my best to test that PR :/
For the next one I must be more strict so that the changes in a PR do not cover more than what is necessary.

[eworm-de]

Do not worry! This functionality was undocumented, so there was no reason for you to test it.

Nevertheless it would be nice to have the behavior back.