Fix item with subitems crash when clicked #83
Conversation
|
This solved the crashing issue but introduced a new one. It prevented zooming in and out on the graph. Will see if there is another solution. |
|
Actually I take that back, the zooming issue happens if I compile the module from scratch without any changes at all. |
src/presets/classic/factory.ts
Outdated
| @@ -28,6 +28,7 @@ export function createItem<S extends BSchemes>( | |||
| } | |||
| return <Item>{ | |||
| ...item, | |||
| subitems: factory.map((data, i) => createItem(data, i, context)) | |||
| subitems: factory.map((data, i) => createItem(data, i, context)), | |||
| handler: Function() | |||
There was a problem hiding this comment.
this is unsafe due to Content Security Policy directive: "script-src"
There was a problem hiding this comment.
also, can you squash commits into a single one with name of the format "fix: "? (unfortunately this part is not covered in the Contribution guide)
https://github.com/retejs/react-plugin/blob/main/src/presets/context-menu/components/Menu.tsx#L39 this is expected behavior. Do you think it should passthrough context menu? |
Claybarn
force-pushed
the
main
branch
2 times, most recently
from
9a571d9 to
2b4e774
Compare
|
I collapsed the commits, let me know if anything else needs changing. |
|
please check CI and Commit linter workflows |
|
|
commit message isn't conventional |
|
anyway, I can merge it into different branch and rebase |
|
🎉 This PR is included in version 2.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Add dummy handler to item with subitems to prevent crashing. Fixes #81.