Allow access request in params #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if it wouldn't be easiser to just pass the const strava = new Strava({ access_token })This way you could implement a logic that do not try to refresh the token if it was passed as a parameter. Does it make sense? |
|
Yep but I can instantiate one strava Instance for my app, get the new refresh token, then start doing request We could also instantiate the strava client with access_token sure ! |
|
I will merge it as it does not break the current API, but we could elaborate more this feature. |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 30, 2022
# [2.1.0](v2.0.2...v2.1.0) (2022-11-30) ### Features * Allow access request in params ([#179](#179)) ([1acea80](1acea80))
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It allows access request in params
also add a methods to get the token