Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

National power rangers' day data and images! #733

Merged
merged 18 commits into from
Aug 26, 2024

Conversation

TinasheMTapera
Copy link
Contributor

Thank you for your submission! Please leave this text as-is when you submit, and then check the checklist.

Usability:

  • This dataset has not already been used in TidyTuesday.
  • The dataset is less than 20MB when saved as a tidy CSV.
  • I can imagine at least one data visualization related to this dataset.

Preparation:

  • cleaning.R has code to download and clean the dataset, resulting in descriptively-named data.frames.
  • I ran saving.R to create csvs and md data dictionaries for each of my data.frames.
  • I filled in descriptions for each variable in each of the {dataset}.md files.
  • I edited the intro.md file to introduce my dataset.
  • I included at least one image for my dataset as a png file.
  • I completed the information in meta.yaml, including descriptive alt text for each image.
  • I provided information in meta.yaml about how to credit me, and deleted any parts of that block that I do not want you to use.

Copy link
Collaborator

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I could make a few tweaks and be done, but there are a couple things that could use your input. Thank you for knocking this out! Note the things I changed, so you're ready for next time, but the most important things are to fill in your credit & the field descriptions in the dictionary!

data/curated/power_rangers/intro.md Outdated Show resolved Hide resolved
data/curated/power_rangers/intro.md Outdated Show resolved Hide resolved
data/curated/power_rangers/intro.md Outdated Show resolved Hide resolved
data/curated/power_rangers/intro.md Outdated Show resolved Hide resolved
data/curated/power_rangers/meta.yaml Outdated Show resolved Hide resolved
data/curated/power_rangers/meta.yaml Outdated Show resolved Hide resolved
data/curated/power_rangers/meta.yaml Outdated Show resolved Hide resolved
data/curated/power_rangers/meta.yaml Outdated Show resolved Hide resolved
data/curated/power_rangers/power_rangers_episodes.md Outdated Show resolved Hide resolved
data/curated/power_rangers/power_rangers_seasons.md Outdated Show resolved Hide resolved
@TinasheMTapera
Copy link
Contributor Author

Hi @jonthegeek, I've amended the changes in 6a14079

Copy link
Collaborator

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I was already planning to update the pre-filled text for the descriptions in the data dictionary, and you helped me see that the snake-case text just makes things confusing. I'll fix that to make it easier for the next contributor 😊

Thanks again!

data/curated/power_rangers/power_rangers_episodes.md Outdated Show resolved Hide resolved
data/curated/power_rangers/power_rangers_seasons.md Outdated Show resolved Hide resolved
@jonthegeek
Copy link
Collaborator

/assign power_rangers 2024-08-27

I *think* this will work.
Need to learn how to escape...
@jonthegeek
Copy link
Collaborator

/assign power_rangers 2024-08-27

I was afraid of this! We're going to have to keep any unused CSVs out of the folder, at least until I update the automatic assigner. That's probably fine; you mention how to download the files.
@jonthegeek
Copy link
Collaborator

/assign power_rangers 2024-08-27

Copy link
Collaborator

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All set! Thanks again!

@jonthegeek jonthegeek merged commit 66bd195 into rfordatascience:master Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants